-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import in doctest example #14067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-s-lee
requested review from
tchaton,
awaelchli,
manskx and
hhsecond
as code owners
August 6, 2022 19:31
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Aug 6, 2022
robert-s-lee
changed the title
typo on doctest that has old lightning_app.core.structures and not the new lightning_app.structures
typo on doctest that has old lightning_app.core and not the new lightning_app.structures
Aug 6, 2022
awaelchli
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
more work needs to be done in the future to fix these imports properly
hhsecond
approved these changes
Aug 8, 2022
awaelchli
changed the title
typo on doctest that has old lightning_app.core and not the new lightning_app.structures
Fix import in doctest example
Aug 8, 2022
otaj
approved these changes
Aug 9, 2022
@Borda I believe this was incorrectly milestoned. |
Borda
pushed a commit
that referenced
this pull request
Aug 16, 2022
(cherry picked from commit d29a552)
lexierule
pushed a commit
that referenced
this pull request
Aug 18, 2022
(cherry picked from commit d29a552)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
docs
Documentation related
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
refactoring was done at some point to move Dict and List to
lightning/src/lightning_app/structures/list.py
andlightning/src/lightning_app/structures/dict.py
The
doctest
inside code still reflects the old structure, and cut/paste of examples no longer works.update the
doctest
to reflect the newlightning_app.structures
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃