Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enable Python 3.10 in full CPU testing #13829

Merged
merged 18 commits into from
Aug 8, 2022
Merged

CI: Enable Python 3.10 in full CPU testing #13829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9bd0844
Update docker images to build
akihironitta Jul 25, 2022
e6ac87e
Update full
akihironitta Jul 25, 2022
97c3a17
revertme: run on draft
akihironitta Jul 25, 2022
2aabf6a
Revert "Update docker images to build"
akihironitta Jul 25, 2022
dad0c07
Update slow
akihironitta Jul 25, 2022
282cbc5
Always run cpu tests
akihironitta Jul 25, 2022
1c197f8
Exclude Python 3.10 with oldest
akihironitta Jul 25, 2022
c2ba1a3
revertme: run on draft
akihironitta Jul 25, 2022
1e44593
docker build base-conda 3.10
akihironitta Jul 25, 2022
cfbccf9
Merge branch 'master' into ci/enable-python3.10
akihironitta Aug 2, 2022
2e1643d
Merge branch 'master' into ci/enable-python3.10
akihironitta Aug 5, 2022
0d0840d
Update conda docker images
akihironitta Aug 5, 2022
a34844d
revert
akihironitta Aug 6, 2022
9f428b0
Revert "Always run cpu tests"
akihironitta Aug 6, 2022
4a8a8ca
Fix changed file detector
akihironitta Aug 6, 2022
4db2227
Revert everything for conda jobs
akihironitta Aug 6, 2022
6d23cbf
Update ci docs
akihironitta Aug 6, 2022
79cfbd3
Update comment
akihironitta Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

| workflow name | workflow file | action | accelerator\* | (Python, PyTorch) | OS |
| -------------------------- | ----------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------- | ------------------------------------------------ | ------------------- |
| Test full | .github/workflows/ci_test-full.yml | Run all tests except for accelerator-specific, standalone and slow tests. | CPU | (3.7, 1.8), (3.7, 1.11), (3.9, 1.8), (3.9, 1.12) | linux, mac, windows |
| Test full | .github/workflows/ci_test-full.yml | Run all tests except for accelerator-specific, standalone and slow tests. | CPU | (3.7, 1.9), (3.7, 1.12), (3.10, 1.12) | linux, mac, windows |
| Test with Conda | .github/workflows/ci_test-conda.yml | Same as ci_test-full.yml but with dependencies installed with conda. | CPU | (3.8, 1.8), (3.8, 1.9), (3.8, 1.10), (3.9, 1.12) | linux |
| Test slow | .github/workflows/ci_test-slow.yml | Run only slow tests. Slow tests usually need to spawn threads and cannot be speed up or simplified. | CPU | (3.7, 1.8) | linux, mac, windows |
| pytorch-lightning (IPUs) | .azure-pipelines/ipu-tests.yml | Run only IPU-specific tests. | IPU | (3.8, 1.9) | linux |
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci-pytorch_test-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,13 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04, windows-2019, macOS-11]
python-version: ["3.7", "3.9"] # minimum, maximum
python-version: ["3.7", "3.10"] # minimum, maximum
requires: ["oldest", "latest"]
release: ["stable"]
exclude:
# There's no distribution of the oldest PyTorch 1.9 for Python 3.10.
# TODO: Remove the exclusion when dropping PyTorch 1.9 support.
- {python-version: "3.10", requires: "oldest"}
# TODO: re-enable RC testing
# include:
# - {os: ubuntu-20.04, python-version: "3.10", requires: "latest", release: "pre"}
Expand All @@ -41,7 +45,7 @@ jobs:
id: skip
shell: bash -l {0}
run: |
FILTER='src/pytorch_lightning|requirements/pytorch|tests/tests_pytorch|examples/pl_*'
FILTER='src/pytorch_lightning|requirements/pytorch|tests/tests_pytorch|examples/pl_*|.github/workflows/ci-pytorch_test-full.yml'
echo "${{ steps.changed-files.outputs.all_changed_files }}" | tr " " "\n" > changed_files.txt
MATCHES=$(cat changed_files.txt | grep -E $FILTER)
echo $MATCHES
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-pytorch_test-slow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
id: skip
shell: bash -l {0}
run: |
FILTER='src/pytorch_lightning|requirements/pytorch|tests/tests_pytorch|examples/pl_*'
FILTER='src/pytorch_lightning|requirements/pytorch|tests/tests_pytorch|examples/pl_*|.github/workflows/ci-pytorch_test-slow.yml'
echo "${{ steps.changed-files.outputs.all_changed_files }}" | tr " " "\n" > changed_files.txt
MATCHES=$(cat changed_files.txt | grep -E $FILTER)
echo $MATCHES
Expand Down