Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Base class for metrics #1293

Closed
wants to merge 10 commits into from
Closed

Add Base class for metrics #1293

wants to merge 10 commits into from

Commits on Mar 30, 2020

  1. Add prototype for base metric

    @justusschock
    justusschock committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    348ad16 View commit details
    Browse the repository at this point in the history

  2. add review comments

    @justusschock
    justusschock authored Mar 30, 2020
    Configuration menu
    Copy the full SHA
    0f86ea1 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. add tests for sync reduce

    @justusschock
    justusschock committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    bbf76eb View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @justusschock
    justusschock committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    ffb4490 View commit details
    Browse the repository at this point in the history

  3. Pep8 Fixes

    @justusschock
    justusschock committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    2154af6 View commit details
    Browse the repository at this point in the history

  4. add test for base metric

    @justusschock
    justusschock committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    81f5fc3 View commit details
    Browse the repository at this point in the history

  5. Pep8 Fix

    @justusschock
    justusschock committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    806ddef View commit details
    Browse the repository at this point in the history

  6. add docs todo

    @Borda
    Borda authored Mar 31, 2020
    Configuration menu
    Copy the full SHA
    b4c0250 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    suggested changes

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
    @justusschock @Borda
    justusschock and Borda authored Mar 31, 2020
    Configuration menu
    Copy the full SHA
    5583844 View commit details
    Browse the repository at this point in the history

  8. Update metric.py

    @justusschock
    justusschock authored Mar 31, 2020
    Configuration menu
    Copy the full SHA
    9f892a7 View commit details
    Browse the repository at this point in the history