Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite accelerator_connector #11448

Merged
merged 71 commits into from
Feb 17, 2022
Merged

Rewrite accelerator_connector #11448

merged 71 commits into from
Feb 17, 2022
+952 −1,042

Commits on Feb 17, 2022

  1. Rewrite accelerator_connector

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    eb3a03c View commit details
    Browse the repository at this point in the history

  2. update

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    50a82d2 View commit details
    Browse the repository at this point in the history

  3. update

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    7307969 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @four4fish
    pre-commit-ci[bot] authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    3999d80 View commit details
    Browse the repository at this point in the history

  5. update

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    c2730f9 View commit details
    Browse the repository at this point in the history

  6. remove print

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    c01aee5 View commit details
    Browse the repository at this point in the history

  7. fix more tests

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d45eba0 View commit details
    Browse the repository at this point in the history

  8. change trainer.gpus

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ec17b31 View commit details
    Browse the repository at this point in the history

  9. fix tests

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ffeea28 View commit details
    Browse the repository at this point in the history

  10. remove gpu avalible check

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    57b1642 View commit details
    Browse the repository at this point in the history

  11. update

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d374aa9 View commit details
    Browse the repository at this point in the history

  12. fix horovod

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    0083b69 View commit details
    Browse the repository at this point in the history

  13. fix horovod

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    7a5c3ba View commit details
    Browse the repository at this point in the history

  14. debug tpu

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ca96f84 View commit details
    Browse the repository at this point in the history

  15. fix global rank

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    e55a524 View commit details
    Browse the repository at this point in the history

  16. fix horovod

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    9996fea View commit details
    Browse the repository at this point in the history

  17. Update pytorch_lightning/utilities/exceptions.py 

    Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
    @four4fish @carmocca
    four4fish and carmocca committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    a14879c View commit details
    Browse the repository at this point in the history

  18. update horovod

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    1626eee View commit details
    Browse the repository at this point in the history

  19. address some ananth's comments

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    e134119 View commit details
    Browse the repository at this point in the history

  20. draft

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    7c1eb85 View commit details
    Browse the repository at this point in the history

  21. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @four4fish
    pre-commit-ci[bot] authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    92deb7e View commit details
    Browse the repository at this point in the history

  22. fix ipus and cli tests

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    8aa1f68 View commit details
    Browse the repository at this point in the history

  23. fix typo

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    f4cca3c View commit details
    Browse the repository at this point in the history

  24. fix tests

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    677c6f1 View commit details
    Browse the repository at this point in the history

  25. fix pre commit

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    5351621 View commit details
    Browse the repository at this point in the history

  26. address comments

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    836eb98 View commit details
    Browse the repository at this point in the history

  27. rename ttp to strategy

    @awaelchli @four4fish
    awaelchli authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    18c4d9e View commit details
    Browse the repository at this point in the history

  28. fix typo

    @awaelchli @four4fish
    awaelchli authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    0bbc1c4 View commit details
    Browse the repository at this point in the history

  29. add typing to constructor

    @awaelchli @four4fish
    awaelchli authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    2d54316 View commit details
    Browse the repository at this point in the history

  30. update on comments

    @awaelchli @four4fish
    awaelchli authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    f7eee05 View commit details
    Browse the repository at this point in the history

  31. typing, documentation improvements, adding todo's

    @awaelchli @four4fish
    awaelchli authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    1022b25 View commit details
    Browse the repository at this point in the history

  32. fix amp_level, amp_type mixup

    @awaelchli @four4fish
    awaelchli authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    932e28a View commit details
    Browse the repository at this point in the history

  33. more typing fixes

    @awaelchli @four4fish
    awaelchli authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    3286de3 View commit details
    Browse the repository at this point in the history

  34. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @four4fish
    pre-commit-ci[bot] authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    774f35d View commit details
    Browse the repository at this point in the history

  35. Update tests/models/test_gpu.py 

    Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
    @four4fish @awaelchli
    four4fish and awaelchli committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    5be85d3 View commit details
    Browse the repository at this point in the history

  36. Update pytorch_lightning/trainer/connectors/accelerator_connector.py 

    Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
    @four4fish @justusschock
    four4fish and justusschock committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    f27d01c View commit details
    Browse the repository at this point in the history

  37. Update pytorch_lightning/trainer/connectors/accelerator_connector.py 

    Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
    @four4fish @justusschock
    four4fish and justusschock committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    74cbfed View commit details
    Browse the repository at this point in the history

  38. Apply suggestions from code review 

    Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
    @four4fish @justusschock @ananthsub
    3 people committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d54ccfc View commit details
    Browse the repository at this point in the history

  39. support bagua

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    653b5b8 View commit details
    Browse the repository at this point in the history

  40. rename distributed_backend to strategy_name

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d000e0d View commit details
    Browse the repository at this point in the history

  41. distributed_backend to strategy_name in tests/

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    344a5e6 View commit details
    Browse the repository at this point in the history

  42. Fix tpu tests

    @kaushikb11 @four4fish
    kaushikb11 authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    1707696 View commit details
    Browse the repository at this point in the history

  43. draft

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    05a03d0 View commit details
    Browse the repository at this point in the history

  44. add device=0 error message and update tests

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d4c78f8 View commit details
    Browse the repository at this point in the history

  45. fix gpu teests

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    77d2cd1 View commit details
    Browse the repository at this point in the history

  46. test revert accelerator auto logic

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d8c5ccc View commit details
    Browse the repository at this point in the history

  47. Tiny update to choose accelerator

    @kaushikb11 @four4fish
    kaushikb11 authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    917039f View commit details
    Browse the repository at this point in the history

  48. fix ipu and gpu tests

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    f2d53fa View commit details
    Browse the repository at this point in the history

  49. add special handling for ipustrategy

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    266d3f8 View commit details
    Browse the repository at this point in the history

  50. Address comments

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    0f833f9 View commit details
    Browse the repository at this point in the history

  51. address comments and add kaushik's suggestions

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    6b434e2 View commit details
    Browse the repository at this point in the history

  52. Apply suggestions from code review 

    Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
    @four4fish @ananthsub
    four4fish and ananthsub committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    3560c55 View commit details
    Browse the repository at this point in the history

  53. fix mypy

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    55547bc View commit details
    Browse the repository at this point in the history

  54. address comments and fix mypy

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    cc684f1 View commit details
    Browse the repository at this point in the history

  55. Updates to attributes

    @kaushikb11 @four4fish
    kaushikb11 authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ce18f52 View commit details
    Browse the repository at this point in the history

  56. Improve exceptions

    @kaushikb11 @four4fish
    kaushikb11 authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    88db830 View commit details
    Browse the repository at this point in the history

  57. Updates to attributes

    @kaushikb11 @four4fish
    kaushikb11 authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ee70db8 View commit details
    Browse the repository at this point in the history

  58. Add utility methods

    @kaushikb11 @four4fish
    kaushikb11 authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    c516830 View commit details
    Browse the repository at this point in the history

  59. Handle zero/empty list values for devices flag

    @kaushikb11 @four4fish
    kaushikb11 authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    8b07218 View commit details
    Browse the repository at this point in the history

  60. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @four4fish
    pre-commit-ci[bot] authored and four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    caaf390 View commit details
    Browse the repository at this point in the history

  61. Apply suggestions from code review 

    Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
    @four4fish @carmocca
    four4fish and carmocca committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    cd12345 View commit details
    Browse the repository at this point in the history

  62. address comments

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    a442852 View commit details
    Browse the repository at this point in the history

  63. minor comments change

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    3152f81 View commit details
    Browse the repository at this point in the history

  64. fix tests

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    2c2e5ac View commit details
    Browse the repository at this point in the history

  65. Merge branch 'master' into rewrite/acc_con

    @four4fish
    four4fish authored Feb 17, 2022
    Configuration menu
    Copy the full SHA
    71dcb82 View commit details
    Browse the repository at this point in the history

  66. minor fix

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    5f32feb View commit details
    Browse the repository at this point in the history

  67. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    f2ab1d6 View commit details
    Browse the repository at this point in the history

  68. add _configure_launcher call to accl_conn

    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    a6ff2c3 View commit details
    Browse the repository at this point in the history

  69. Merge branch 'rewrite/acc_con' of https://github.com/four4fish/pytorc… 

    …h-lightning into rewrite/acc_con
    @four4fish
    four4fish committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    62ce92e View commit details
    Browse the repository at this point in the history

  70. Apply suggestions from code review 

    Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
    @four4fish @carmocca
    four4fish and carmocca authored Feb 17, 2022
    Configuration menu
    Copy the full SHA
    869e571 View commit details
    Browse the repository at this point in the history

  71. Apply suggestions from code review 

    Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
    @four4fish @carmocca
    four4fish and carmocca authored Feb 17, 2022
    Configuration menu
    Copy the full SHA
    9568f3b View commit details
    Browse the repository at this point in the history