Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TrainerOptimizersMixin and move functionality to core/optimizer.py #11155

Merged
merged 38 commits into from
Dec 23, 2021
Merged

Deprecate TrainerOptimizersMixin and move functionality to core/optimizer.py #11155

merged 38 commits into from
Dec 23, 2021

Commits on Dec 18, 2021

  1. refactor init_optimizers

    @daniellepintz
    daniellepintz committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    68d60fa View commit details
    Browse the repository at this point in the history

  2. fix tests

    @daniellepintz
    daniellepintz committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    e7e3b59 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @daniellepintz
    daniellepintz committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    628e4a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. fix another test

    @daniellepintz
    daniellepintz committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    68caa57 View commit details
    Browse the repository at this point in the history

  2. attempt to fix deepspeed test

    @daniellepintz
    daniellepintz committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    0396959 View commit details
    Browse the repository at this point in the history

  3. addr comments

    @daniellepintz
    daniellepintz committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    b645134 View commit details
    Browse the repository at this point in the history

  4. deprecate optimizer mixin

    @daniellepintz
    daniellepintz committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    47bdae1 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. addr comments

    @daniellepintz
    daniellepintz committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    aff9de3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-… 

    …lightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    74a3033 View commit details
    Browse the repository at this point in the history

  3. move _convert_to_lightning_optimizer to core/optimizer.py

    @daniellepintz
    daniellepintz committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    3d1faaa View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. fix typing and docstring

    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    8c1267f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-… 

    …lightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    4a1ee1a View commit details
    Browse the repository at this point in the history

  3. remove strategy refactor

    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    108c4a2 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    a768823 View commit details
    Browse the repository at this point in the history

  5. small fix

    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    b27e2e1 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'optimizers_mixin' of github.com:daniellepintz/pytorch-l… 

    …ightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e8d6cf6 View commit details
    Browse the repository at this point in the history

  7. fix mypy

    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    7d72f56 View commit details
    Browse the repository at this point in the history

  8. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    4fda88f View commit details
    Browse the repository at this point in the history

  9. addr comment

    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    be56fcd View commit details
    Browse the repository at this point in the history

  10. Merge branch 'optimizers_mixin' of github.com:daniellepintz/pytorch-l… 

    …ightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0da03c8 View commit details
    Browse the repository at this point in the history

  11. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    779c0a4 View commit details
    Browse the repository at this point in the history

  12. fix test

    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    362a1b7 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'optimizers_mixin' of github.com:daniellepintz/pytorch-l… 

    …ightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    81c6788 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. addr comments

    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    493a582 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-… 

    …lightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    b20d6f4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-… 

    …lightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    1c30527 View commit details
    Browse the repository at this point in the history

  4. fix merge conflicts from strategy

    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8b80304 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    5397d2f View commit details
    Browse the repository at this point in the history

  6. addr comments

    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    5da0649 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'optimizers_mixin' of github.com:daniellepintz/pytorch-l… 

    …ightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    f320402 View commit details
    Browse the repository at this point in the history

  8. fix whitespace

    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    119bc58 View commit details
    Browse the repository at this point in the history

  9. fix weakref test

    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ecb3c60 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-… 

    …lightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    fd1b14d View commit details
    Browse the repository at this point in the history

  11. add comment

    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8ba6f37 View commit details
    Browse the repository at this point in the history

  12. addr comments

    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    d2c6b6e View commit details
    Browse the repository at this point in the history

  13. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    bb6ba78 View commit details
    Browse the repository at this point in the history

  14. fix mypy

    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    41bbfb8 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'optimizers_mixin' of github.com:daniellepintz/pytorch-l… 

    …ightning into optimizers_mixin
    @daniellepintz
    daniellepintz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    126533d View commit details
    Browse the repository at this point in the history