-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch of displayed 'epoch' #675
Comments
Indeed, the inconsistency of zero-based/one-based epoch is very confusing. I think we should use zero-based only. |
@matthew-z i agree it should be zero based. want to submit a PR? |
@williamFalcon I'll try this weekend. |
@matthew-z @neggert @williamFalcon @Borda I found a 'one epoch'-based API in |
I can't quite wrap my head around this. If you make it zero based, then when the progress bar shows |
I agree with you, but I think zero-based would be better than one-based. Zero-based implementations are:
One-based implementations are:
I think what of most influensive in these items are "metrics.csv" and "_ckpt_epoch_{0-based epoch number}.ckpt." |
agreed. let’s do zero-based |
@williamFalcon Is it ok that |
we are using |
🐛 Bug
The display of epoch's number mismatches between the progress bar and the checkpoint indicator. I wonder this mismatch could confuse users.
I think that to change checkpoint and metrics.csv causes a serious problem.
So progress bar should be changed in my opinion.
What do you think about it?
Environment
pip install git+https://github.com/williamFalcon/pytorch-lightning.git@master --upgrade
The text was updated successfully, but these errors were encountered: