Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts in docs as plotly plots #5630

Closed
Borda opened this issue Jan 23, 2021 · 4 comments
Closed

charts in docs as plotly plots #5630

Borda opened this issue Jan 23, 2021 · 4 comments
Labels
docs Documentation related help wanted Open to be worked on

Comments

@Borda
Copy link
Member

Borda commented Jan 23, 2021 •
edited
Loading

🚀 Feature

replace all static plots in docs to Plotly
see: Lightning-Universe/lightning-bolts#537

Motivation

  • save space (no need for png images),
  • better control over the content
  • native resolution even for details/zoom-in

Pitch

full transparency

Alternative

http://nipy.org/nipy/devel/guidelines/sphinx_helpers.html#inserting-matplotlib-plots
@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on labels Jan 23, 2021
@Borda Borda added this to the 1.2 milestone Jan 23, 2021
@edenlightning edenlightning modified the milestones: 1.2, 1.3 Feb 8, 2021
@akihironitta
Copy link
Contributor

btw do we have charts in lightning docs? I could find some (ugly screenshots of TensorBoard) in Bolts, but I couldn't here.

@edenlightning edenlightning removed this from the v1.3 milestone Apr 27, 2021
@edenlightning edenlightning added the docs Documentation related label May 9, 2021
@stale stale bot added the won't fix This will not be worked on label Jun 8, 2021
@Lightning-AI Lightning-AI deleted a comment from stale bot Jun 9, 2021
@stale stale bot removed the won't fix This will not be worked on label Jun 9, 2021
@Borda Borda added this to the v1.4 milestone Jun 9, 2021
@edenlightning edenlightning modified the milestones: v1.4, v1.4.x Jul 6, 2021
@Borda Borda modified the milestones: v1.4.x, v1.5 Jul 23, 2021
@Borda Borda mentioned this issue Jul 28, 2021
Open
@awaelchli awaelchli modified the milestones: v1.5, v1.6 Nov 4, 2021
@kaushikb11 kaushikb11 self-assigned this Jan 12, 2022
@carmocca carmocca added this to To do in Documentation via automation Feb 1, 2022
@Borda Borda mentioned this issue Feb 8, 2022
Merged
4 tasks
@Borda Borda modified the milestones: 1.6, 1.6.x Mar 21, 2022
@carmocca
Copy link
Contributor

Is this worth doing? What plots would we update exactly?

@carmocca carmocca removed this from the 1.6.x milestone Mar 21, 2022
@carmocca carmocca removed the feature Is an improvement or enhancement label Mar 21, 2022
@carmocca carmocca removed this from To do in Documentation Mar 21, 2022
@akihironitta
Copy link
Contributor

I believe we can close this because AFAIK we don't have plots in the docs.

@Borda
Copy link
Member Author

Borda commented Apr 1, 2022

It could be used for benchmark results, cc: @kaushikb11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation related help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@awaelchli @Borda @carmocca @akihironitta @kaushikb11 @edenlightning