Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IterableDataset breaks 1.1 compatibility #491

Closed
volcacius opened this issue Nov 11, 2019 · 10 comments · Fixed by #549 or #552
Closed

IterableDataset breaks 1.1 compatibility #491

volcacius opened this issue Nov 11, 2019 · 10 comments · Fixed by #549 or #552
Labels
bug Something isn't working

Comments

@volcacius
Copy link

A recently introduced feature unfortunately breaks compability with Pytorch 1.1.0.

Describe the bug
IterableDataset support, introduced in issue 323, requires Pytorch 1.2.0+.

To Reproduce
In a python environment with Pytorch 1.1.0 do:
import pytorch_lightning

Expected behavior
Compatibility with Pytorch 1.1.0. I'm filing it as a bug report rather than a docs fix since the dependency on 1.2.0+ introduced by issue 323 doesn't seem to be intentional.

@volcacius volcacius added the bug Something isn't working label Nov 11, 2019
@williamFalcon
Copy link
Contributor

good catch. mind submitting a PR? was not the intention of that fix :)

We want to support 1.1

@Borda
Copy link
Member

Borda commented Nov 11, 2019

I have played with versions and it seems to me that it does not run even with 1.2.0; see #462

@williamFalcon
Copy link
Contributor

williamFalcon commented Nov 11, 2019

weird. let’s patch it and make a nee release? in the meantime, put a note on the readme to use 0.5.2.1 if you need pt 1.1 or 1.2 support?

@Borda
Copy link
Member

Borda commented Nov 12, 2019

you may rather change requirements.txt and after fix put it back...
I see that >=1.2.0 is there already for some time... 8-)

@shreyasbapat
Copy link
Contributor

Is this already fixed? I see that torch 1.2.0 is already in requirements.txt ?

@Borda
Copy link
Member

Borda commented Nov 12, 2019

I think not yet...8-)

@shreyasbapat
Copy link
Contributor

Do you suggest torch 1.3.0 ?

@williamFalcon
Copy link
Contributor

we need to support 1.2.0 :)

@williamFalcon
Copy link
Contributor

@Borda did we get this fixed? is PT 1.2 supported now? If not, what do we need to do?

@Borda
Copy link
Member

Borda commented Nov 25, 2019

I have not worked on it yet (bit busy with docs), hopefully this week...

This was referenced Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants