Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_gpu_memory should use a GPUStatsMonitor #3333

Closed
carmocca opened this issue Sep 2, 2020 · 3 comments
Closed

log_gpu_memory should use a GPUStatsMonitor #3333

carmocca opened this issue Sep 2, 2020 · 3 comments
Labels
feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on refactor won't fix This will not be worked on

Comments

@carmocca
Copy link
Contributor

carmocca commented Sep 2, 2020

🐛 Bug

Trainer.log_gpu_memory should use a GPUStatsMonitor callback

The only extra feature of log_gpu_memory is the ability to print the min and max memory used. We could add that to GPUStatsMemory if deemed necessary.

cc @rohitgr7
#2932 (comment)
@carmocca carmocca added bug Something isn't working help wanted Open to be worked on labels Sep 2, 2020
@Borda
Copy link
Member

Borda commented Sep 2, 2020

@carmocca mind draft a PR? 🐰

@carmocca
Copy link
Contributor Author

carmocca commented Sep 3, 2020

Should I wait until refactors are over?

@Borda Borda added the good first issue Good for newcomers label Sep 15, 2020
@carmocca carmocca mentioned this issue Sep 20, 2020
Closed
7 tasks
@edenlightning edenlightning added refactor feature Is an improvement or enhancement and removed bug Something isn't working labels Sep 23, 2020
@stale
Copy link

stale bot commented Oct 23, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Oct 23, 2020
@stale stale bot closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on refactor won't fix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace log_gpu_memory with gpu_stats_callback
3 participants
@Borda @carmocca @edenlightning