Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Step for Epoch Clarified #3164

Closed
dulayjm opened this issue Aug 25, 2020 · 3 comments
Closed

Validation Step for Epoch Clarified #3164

dulayjm opened this issue Aug 25, 2020 · 3 comments
Labels
feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on

Comments

@dulayjm
Copy link

dulayjm commented Aug 25, 2020

🚀 Feature

This simple change would add the num_validation_sanity_steps flag to also include fullEpoch in addition to the synonymous -1 flag, to add clarity to the end-user.

Motivation

I grew frustrated with trying to find a way to easily run an entire validation epoch before using training loops in pytorch-lightning. After finding this parameter (#2246), I still did not like how the -1 flag works. This also confused a colleague of mine, so I decided to submit this change as a means to add clarity to the end-user.

Pitch

Allow -1 and fullEpoch flags to run the validation sanity step on an entire batch prior to training

Alternatives

Additional context

Pull Request

#3166

@dulayjm dulayjm added feature Is an improvement or enhancement help wanted Open to be worked on labels Aug 25, 2020
@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@Borda
Copy link
Member

Borda commented Aug 25, 2020

Thx for your PR 👍

@Borda Borda linked a pull request Aug 25, 2020 that will close this issue
7 tasks
@stale
Copy link

stale bot commented Oct 21, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Oct 21, 2020
@stale stale bot closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on
Projects
None yet
2 participants