Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valdation_epoch_end won't log if no logging is done in validation_step #3000

Closed
rohitgr7 opened this issue Aug 16, 2020 · 2 comments · Fixed by #3060
Closed

valdation_epoch_end won't log if no logging is done in validation_step #3000

rohitgr7 opened this issue Aug 16, 2020 · 2 comments · Fixed by #3060
Assignees
@williamFalcon
Labels
bug Something isn't working checkpointing Related to checkpointing help wanted Open to be worked on
Milestone
pl:1.0

Comments

@rohitgr7
Copy link
Contributor

rohitgr7 commented Aug 16, 2020 •
edited by edenlightning
Loading

🐛 Bug

@edenlightning looks like setting both logger=False and prog_bar=False won't do anything. If this is intended, maybe we should add a warning or something.

Also saw another issue, if I don't log anything in validation_step then logged values in validation_epoch_end won't be logged too even if we set logger=True. Updated the notebook attatched above for the same to verify.

Code sample

https://colab.research.google.com/drive/1Os9oSPK_rwwutcFdZTDsBaMc2IrqkSrP#scrollTo=3BJmPqHwX6WA

Environment

pl: master
env: colab
@rohitgr7 rohitgr7 added bug Something isn't working help wanted Open to be worked on labels Aug 16, 2020
@williamFalcon williamFalcon mentioned this issue Aug 19, 2020
Merged
@rohitgr7 rohitgr7 reopened this Aug 22, 2020
@Borda Borda added the Result label Sep 4, 2020
@edenlightning edenlightning added this to the 0.9.x milestone Sep 23, 2020
@edenlightning edenlightning added the checkpointing Related to checkpointing label Sep 23, 2020
@rohitgr7 rohitgr7 mentioned this issue Oct 3, 2020
Closed
@edenlightning edenlightning modified the milestones: 0.9.x, 1.0 Oct 4, 2020
@edenlightning edenlightning changed the title checkpoint_file is not updated with metric values when using EvalResult valdation_epoch_end won't log if no logging is done in validation_step Oct 4, 2020
@Lightning-AI Lightning-AI deleted a comment from rohitgr7 Oct 4, 2020
@Lightning-AI Lightning-AI deleted a comment from rohitgr7 Oct 4, 2020
@edenlightning
Copy link
Contributor

Edited the original bug with the current issue.

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Oct 4, 2020

@edenlightning it's resolved in a recent PR. Forgot to close it. Will close now.

@rohitgr7 rohitgr7 closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamFalcon williamFalcon

Labels
bug Something isn't working checkpointing Related to checkpointing help wanted Open to be worked on
Projects
None yet
Milestone
pl:1.0
Development

Successfully merging a pull request may close this issue.

re-enabled naming metrics in ckpt name Lightning-AI/pytorch-lightning
4 participants
@williamFalcon @Borda @rohitgr7 @edenlightning