Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataModule] Datamodule setup in docs shows non-existent stage arg #2751

Closed
ydcjeff opened this issue Jul 29, 2020 · 3 comments · Fixed by #2755
Closed

[DataModule] Datamodule setup in docs shows non-existent stage arg #2751

ydcjeff opened this issue Jul 29, 2020 · 3 comments · Fixed by #2755
Assignees
@nateraw
Labels
docs Documentation related help wanted Open to be worked on

Comments

@ydcjeff
Copy link
Contributor

ydcjeff commented Jul 29, 2020

🐛 Bug

To Reproduce

Colab Minimal code

Expected behavior

DataModule should call prepare_data and setup

Environment

  • Colab

Additional context

PL Version: 0.9.0rc3
@ydcjeff ydcjeff added bug Something isn't working help wanted Open to be worked on labels Jul 29, 2020
@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@nateraw nateraw added the docs Documentation related label Jul 29, 2020
@nateraw nateraw mentioned this issue Jul 29, 2020
Merged
7 tasks
@nateraw nateraw changed the title AttributeError: 'MNISTDataModule' object has no attribute 'val_dataset' [DataModule] prepare_data and setup should be called by trainer Jul 29, 2020
@nateraw nateraw changed the title [DataModule] prepare_data and setup should be called by trainer [DataModule] Datamodule setup in docs shows non-existent stage arg Jul 29, 2020
@nateraw nateraw removed the bug Something isn't working label Jul 29, 2020
@Borda
Copy link
Member

Borda commented Jul 31, 2020

I guess it was changed recently, @nateraw mind update docs? 🐰
or @ydcjeff mind sending a PR with update according to actuals code...

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jul 31, 2020

I think @nateraw has updated the docs along in #2755

@Borda Borda closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nateraw nateraw

Labels
docs Documentation related help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call DataModule hooks implicitly in trainer nateraw/pytorch-lightning
3 participants
@Borda @nateraw @ydcjeff