When I call Trainer.test it calls both "test" and "fit" stages of setup - should it just be "test"

[jloveric]

🐛 Bug

When I call Trainer.test it calls both "test" and "fit" stages of "setup" function. Shouldn't it just call test?

To Reproduce

You can actually look through the code to see that this will happen since self.fit() is called. Follow trainer.test() then choose the function self.__test_given_model(model, test_dataloaders) and then self.fit(model) is called. Also, you can just print out "stage" in the setup function and you will see both "fit" and "test" are called when trainer.test(model=model, test_dataloaders=dataloaders) is called. I'm using the "fit" value for training, should I be using something else?

[rohitgr7]

Can you check on master? It's fixed #2624.

[Borda]

@yukw777 mind have look? :]

[rohitgr7]

@Borda it's already fixed on master.