Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace_sampler_ddp doesn't create a shuffled sampler #2703

Closed
ibeltagy opened this issue Jul 25, 2020 · 0 comments · Fixed by #2789
Closed

replace_sampler_ddp doesn't create a shuffled sampler #2703

ibeltagy opened this issue Jul 25, 2020 · 0 comments · Fixed by #2789
Labels
bug Something isn't working distributed Generic distributed-related topic help wanted Open to be worked on

Comments

@ibeltagy
Copy link
Contributor

ibeltagy commented Jul 25, 2020 •
edited
Loading

🐛 Bug

The DistributedSampler created using replace_sampler_ddp is not shuffled. Check the kwargs here

Expected behavior

If training dataloader, create a shuffled DistributedSampler, else create a non-shuffled sampler. Even though the train flag is passed to the function here, it is ignored.

Environment

pytorch-lightning master
@ibeltagy ibeltagy added bug Something isn't working help wanted Open to be worked on labels Jul 25, 2020
@edenlightning edenlightning added the distributed Generic distributed-related topic label Jul 29, 2020
@rohitgr7 rohitgr7 mentioned this issue Aug 1, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working distributed Generic distributed-related topic help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shuffle for distributed sampler Lightning-AI/pytorch-lightning
2 participants
@ibeltagy @edenlightning