Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apex gradient clipping #2556

Closed
ruotianluo opened this issue Jul 8, 2020 · 1 comment · Fixed by #2829
Closed

apex gradient clipping #2556

ruotianluo opened this issue Jul 8, 2020 · 1 comment · Fixed by #2829
Labels
bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on

Comments

@ruotianluo
Copy link
Contributor

#🐛 Bug

It seems when apex + gradient clipping is not handled explicitly.
I see note here https://nvidia.github.io/apex/advanced.html#gradient-clipping.
where amp.master_params needs to be used.

Is what's in this repo correct or not?
@ruotianluo ruotianluo added bug Something isn't working help wanted Open to be worked on labels Jul 8, 2020
@Borda
Copy link
Member

Borda commented Aug 4, 2020

@ruotianluo mind send a PR? 🐰

@Borda Borda added the good first issue Good for newcomers label Aug 4, 2020
@ruotianluo ruotianluo mentioned this issue Aug 4, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix apex gradient clipping ruotianluo/pytorch-lightning
2 participants
@Borda @ruotianluo