Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSNR metric in metrics #2474

Closed
rohitgr7 opened this issue Jul 2, 2020 · 6 comments · Fixed by #2483
Closed

PSNR metric in metrics #2474

rohitgr7 opened this issue Jul 2, 2020 · 6 comments · Fixed by #2483
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@rohitgr7
Copy link
Contributor

rohitgr7 commented Jul 2, 2020

🚀 Feature

Can we have PSNR metric in the metrics module?

Motivation

This metric is used in Image generative models eg. super-resolution.
@rohitgr7 rohitgr7 added feature Is an improvement or enhancement help wanted Open to be worked on labels Jul 2, 2020
@InCogNiTo124
Copy link
Contributor

Actually I think I have implemented it somewhere

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Jul 2, 2020

Couldn't find it in lightning.

@InCogNiTo124
Copy link
Contributor

Couldn't find it in lightning.

No, sorry, I meant I've implemented it for my needs, and I'm about to open a PR where I add it

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Jul 2, 2020 •
edited
Loading

Oh! I have worked with it too. It's just log inverse mse. Thought it would be a good addition to lightning metrics. I think it needs to be discussed/approved by core maintainers first then only a PR can be submitted.

@InCogNiTo124
Copy link
Contributor

Oh, okay.

I've added a stub here in my fork

@Borda
Copy link
Member

Borda commented Jul 3, 2020

@InCogNiTo124 mind send a PR adding it to lightning?

@InCogNiTo124 InCogNiTo124 mentioned this issue Jul 3, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PSNR implementation
3 participants
@Borda @InCogNiTo124 @rohitgr7