Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddp with subprocess does not work with hydra #2104

Closed
haichao592 opened this issue Jun 7, 2020 · 1 comment · Fixed by #2115
Closed

ddp with subprocess does not work with hydra #2104

haichao592 opened this issue Jun 7, 2020 · 1 comment · Fixed by #2115
Milestone

Comments

@haichao592
Copy link

Thanks for the great work.

The recent change replaced .spawn with subprocess which forces pass "--gpus" flag. This works fine for the project using argparse to parse arguments. But it does not work with hydra since the arguments in hydra are passed like "gpus=2" not "--gpus 2". The "--somearg val" in hydra is used for specific purpose not for arguments passing.

Could you please provide the support for hydra under the new context?
Thanks.

https://github.com/PyTorchLightning/pytorch-lightning/blob/82a20296e308a67c8d9202e4cbdf92a44b90b077/pytorch_lightning/trainer/distrib_data_parallel.py#L370-L372

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2020

Hi! thanks for your contribution!, great first issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants