Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi GPU tests for torchelastic nightly #2088

Closed
edenlightning opened this issue Jun 5, 2020 · 5 comments
Closed

Add multi GPU tests for torchelastic nightly #2088

edenlightning opened this issue Jun 5, 2020 · 5 comments
Assignees
@Borda
Labels
ci Continuous Integration help wanted Open to be worked on
Projects
Test Coverage
Milestone
pl:1.6

Comments

@edenlightning
Copy link
Contributor

edenlightning commented Jun 5, 2020 •
edited
Loading

Add a test to CircleCI that spawns to torchelastic and verify that raining works and that the training model returned is correct.
@edenlightning edenlightning added help wanted Open to be worked on ci Continuous Integration priority: 0 High priority task labels Jun 5, 2020
@edenlightning edenlightning changed the title [test] Add tests for torchelastic nightly [test] Add multi GPU tests for torchelastic nightly Jun 5, 2020
@edenlightning edenlightning added this to the 0.8.0 milestone Jun 8, 2020
@Borda Borda modified the milestones: 0.8.0, 0.9.0 Jun 9, 2020
@Borda
Copy link
Member

Borda commented Jun 9, 2020

is this done with ddp_spawn #2115 @williamFalcon ?

@Borda Borda added the good first issue Good for newcomers label Aug 4, 2020
@edenlightning edenlightning modified the milestones: 0.9.0, 0.9.x Aug 18, 2020
@edenlightning edenlightning modified the milestones: 0.9.x, 1.1 Sep 22, 2020
@stale stale bot added the won't fix This will not be worked on label Nov 3, 2020
@edenlightning edenlightning removed won't fix This will not be worked on Hacktoberfest good first issue Good for newcomers labels Nov 3, 2020
@edenlightning edenlightning added this to To do in Test Coverage Nov 3, 2020
@Borda
Copy link
Member

Borda commented Nov 26, 2020

@edenlightning I have a hard time finding how the torchelastic is installed...
so basically we just want to test it on the nightly version, or something else?

@edenlightning edenlightning added the duplicate This issue or pull request already exists label Nov 30, 2020
@edenlightning
Copy link
Contributor Author

blocked by https://github.com/PyTorchLightning/pytorch-lightning/issues/2089

@edenlightning edenlightning removed the duplicate This issue or pull request already exists label Nov 30, 2020
@edenlightning edenlightning modified the milestones: 1.1, 1.2 Nov 30, 2020
@Borda Borda changed the title [test] Add multi GPU tests for torchelastic nightly [blocked by #2089] Add multi GPU tests for torchelastic nightly Nov 30, 2020
@Borda Borda pinned this issue Dec 23, 2020
@Borda Borda unpinned this issue Dec 23, 2020
@edenlightning edenlightning modified the milestones: 1.2, 1.3 Feb 8, 2021
@edenlightning
Copy link
Contributor Author

@Borda still blocked?

@edenlightning edenlightning changed the title [blocked by #2089] Add multi GPU tests for torchelastic nightly Add multi GPU tests for torchelastic nightly Feb 16, 2021
@Lightning-AI Lightning-AI deleted a comment from stale bot Mar 1, 2021
@edenlightning edenlightning modified the milestones: v1.3, v1.4 Apr 27, 2021
@edenlightning
Copy link
Contributor Author

@Borda ?

@edenlightning edenlightning removed the priority: 0 High priority task label May 9, 2021
@Borda Borda self-assigned this May 9, 2021
@edenlightning edenlightning modified the milestones: v1.4, v1.5 Jun 30, 2021
@awaelchli awaelchli modified the milestones: v1.5, v1.6 Nov 4, 2021
@carmocca carmocca closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Borda Borda

Labels
ci Continuous Integration help wanted Open to be worked on
Projects
No open projects
Test Coverage
To do
Milestone
pl:1.6
Development

No branches or pull requests
6 participants
@awaelchli @Borda @SeanNaren @carmocca @tchaton @edenlightning