Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Trainer states #1633

Closed
Borda opened this issue Apr 27, 2020 · 5 comments · Fixed by #2541
Closed

add Trainer states #1633

Borda opened this issue Apr 27, 2020 · 5 comments · Fixed by #2541
Assignees
Labels
feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on
Milestone

Comments

@Borda
Copy link
Member

Borda commented Apr 27, 2020

🚀 Feature

Add trainer states so in each time user get info what is happening

Motivation

simplify the return values and clean up the interface

Pitch

The state will be implemented as enum and updated according to Trainer phase:

  • INITIALIZE
  • RUNNING
  • FINISHED
  • TEARING_DOWN
  • TERMINATED
  • ...
@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on good first issue Good for newcomers labels Apr 27, 2020
@Borda Borda added this to the 0.7.5 milestone Apr 27, 2020
@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@zerogerc
Copy link
Contributor

zerogerc commented Jul 2, 2020

As I understood it right, the change is to add enum with phases, add corresponding updates, and logging of the current phase. @Borda I can take it as my first issue.

@Borda
Copy link
Member Author

Borda commented Jul 2, 2020

@zerogerc cool, that it adds an enum (with possible texts) and change the states according to the training phase...
if you need anything, just ping me on slack 🐰

@awaelchli
Copy link
Member

Don't we want to control these states with decorators? I think having the code for these state changes mixed with the core training logic is a bit distracting and fragile, don't you think?

@Borda
Copy link
Member Author

Borda commented Jul 9, 2020

Don't we want to control these states with decorators? I think having the code for these state changes mixed with the core training logic is a bit distracting and fragile, don't you think?

well, decorators would be nicer :] @awaelchli mind comment/suggest on the open PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants