Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from tqdm to fastprogress for jupyter-lab friendly progress bars #1500

Closed
tcwalther opened this issue Apr 15, 2020 · 5 comments
Closed
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@tcwalther
Copy link

tcwalther commented Apr 15, 2020

🚀 Feature

Use https://github.com/fastai/fastprogress instead of tqdm for displaying progress bars.

Motivation

tqdm doesn't work well with Jupyter Lab. This creates issues with pytorch-lightning's progress bars, where each validation bar creates a newline in the cell output: #1399. This is a well-known issue in jupyter-widgets: jupyter-widgets/ipywidgets#1845

The Fast.ai people developed fastprogress as a replacement for exactly this reason.

Pitch

Replace tqdm with fastprogress.

Alternatives

The alternative is to wait for jupyter-widgets to fix the issue on their side. Given that this issue has been around since November 2017, I'm not too hopeful that it will happen, though. It looks like this would require major design changes in ipywidgets and/or jupyter-lab.

Additional context

Motivated by #1399.

@tcwalther tcwalther added feature Is an improvement or enhancement help wanted Open to be worked on labels Apr 15, 2020
@awaelchli awaelchli mentioned this issue Apr 15, 2020
7 tasks
@awaelchli
Copy link
Member

Could be done as a follow up to the progress bar callback PR ❤️

@williamFalcon
Copy link
Contributor

@tcwalther sorry, we don't want to add more dependencies to lightning.
If this is needed, then it should be added as a callback with a fresh implementation, but no dependencies :)

@ethanwharris
Copy link
Member

Perhaps a fast progress callback could be a good lightning bolt (https://github.com/PyTorchLightning/lightning-bolts)???

@Borda
Copy link
Member

Borda commented Apr 15, 2020

so open an issue there?

@ethanwharris
Copy link
Member

@Borda Borda reopened this Jun 12, 2020
@Borda Borda closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

5 participants