-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metrics] Automatic reduction of metrics from several validation steps #1249
Comments
I think this is cool. Things that come to my mind:
|
I think that collate_metrics function would need at least:
The code will start to be quite messy soon. |
I guess that if add metrics as a class discussed in #973 we may define for each custom reduction method, right? |
@Borda I think we will integrate this into an automated metric calculation plan that also has a different collation per metric. |
@justusschock can we close this issue? was it fixed? |
@edenlightning not yet. We haven't yet come to implementing accumulation for metrics. This will be V2 of metrics |
With PR #3245 merge, this is solved now. Each metric now have a
Closing this issue. |
🚀 Feature
As per the slack, it could be cool to implement this. More detail below.
Motivation
To avoid the user having to do this
Pitch
Something like this:
Alternatives
Can just add the above to lightning module and use it anyway.
The text was updated successfully, but these errors were encountered: