Skip to content

Commit

Permalink
handle fsspec inconsistency in PyArrowHDFS (#3805)
Browse files Browse the repository at this point in the history
  • Loading branch information
f4hy authored Oct 3, 2020
1 parent 74484ed commit b14c4d4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion pytorch_lightning/loggers/tensorboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@ def _get_next_version(self):
return 0

existing_versions = []
for d in self._fs.ls(root_dir):
for listing in self._fs.listdir(root_dir):
d = listing["name"]
bn = os.path.basename(d)
if self._fs.isdir(d) and bn.startswith("version_"):
dir_ver = bn.split("_")[1].replace('/', '')
Expand Down
4 changes: 2 additions & 2 deletions pytorch_lightning/trainer/connectors/checkpoint_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def restore_hpc_weights_if_needed(self, model: LightningModule):
folderpath = str(self.trainer.weights_save_path)
fs = get_filesystem(folderpath)
if fs.exists(folderpath):
files = [os.path.basename(f) for f in fs.ls(folderpath)]
files = [os.path.basename(f['name']) for f in fs.listdir(folderpath)]
hpc_weight_paths = [x for x in files if 'hpc_ckpt' in x]

# if hpc weights exist restore model
Expand Down Expand Up @@ -333,7 +333,7 @@ def hpc_load(self, folderpath, on_gpu):

def max_ckpt_in_folder(self, path, name_key='ckpt_'):
fs = get_filesystem(path)
files = [os.path.basename(f) for f in fs.ls(path)]
files = [os.path.basename(f["name"]) for f in fs.listdir(path)]
files = [x for x in files if name_key in x]
if len(files) == 0:
return 0
Expand Down

0 comments on commit b14c4d4

Please sign in to comment.