Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor dcgan-import fix #921

Merged
merged 9 commits into from
Oct 31, 2022
Merged

Conversation

Atharva-Phatak
Copy link
Contributor

@Atharva-Phatak Atharva-Phatak commented Oct 28, 2022

What does this PR do?

Reviews DCGAN implementations in #839.

Though GAN implementation is very specific. GANS module requires some discussion on how the package should be structured.

Part of #839

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Atharva-Phatak
Copy link
Contributor Author

I checked the resnet download link its working :). I am taking a look at the retinanet tests. More or less it looks like an azure pipeline issue :(

@mergify mergify bot added the ready label Oct 28, 2022
@Borda
Copy link
Member

Borda commented Oct 28, 2022

I checked the resnet download link its working :). I am taking a look at the retinanet tests. More or less it looks like an azure pipeline issue :(

that seems to be unrelated... that is fine :)

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atharva-Phatak Thank you for working on this!

Could you also update the docstring so that it uses the new way of specifying the accelerator?
https://github.com/Lightning-AI/lightning-bolts/blob/43f869ff3f09c2d967d850525d0723da51db48b6/pl_bolts/models/gans/dcgan/dcgan_module.py#L30

Trainer(accelerator="gpu", devices=2)

@akihironitta
Copy link
Contributor

I am taking a look at the retinanet tests.

@Atharva-Phatak FYI, the failure of the test case is being investigated by @rohitgr7 via #910.

@Atharva-Phatak
Copy link
Contributor Author

I am taking a look at the retinanet tests.

@Atharva-Phatak FYI, the failure of the test case is being investigated by @rohitgr7 via #910.

Updated the docstring. Thanks for the letting me know :)

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Atharva-Phatak! LGTM!

@Borda Borda enabled auto-merge (squash) October 31, 2022 12:32
@Borda Borda merged commit c91726f into Lightning-Universe:master Oct 31, 2022
@otaj otaj mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants