Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset specific args method to CIFAR10, ImageNet, MNIST, and STL10 #890

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Sep 22, 2022

What does this PR do?

Discussed in #874

Add a static method add_dataset_specific_args that adds data_dir, num_workers, and batch_size to CLI parser for CIFAR10DataModule, ImageNetDataModule, MNISTDataModule, and STL10DataModule

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • N/A Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • N/A If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the datamodule Anything related to datamodules label Sep 22, 2022
@otaj otaj merged commit cbe4143 into Lightning-Universe:master Sep 23, 2022
@mergify mergify bot added the ready label Sep 23, 2022
@matsumotosan matsumotosan deleted the dataset_args branch September 23, 2022 11:13
@matsumotosan matsumotosan mentioned this pull request Sep 23, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants