Reviewing GAN basics, VisionDataModule, MNISTDataModule, CIFAR10DataModule #843

shivammehta25 · 2022-07-26T16:11:52Z

What does this PR do?

Part of #839

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes?
Did you write any new necessary tests? [not needed for typos/docs]
Did you verify new and existing tests pass locally with your changes?
If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

for more information, see https://pre-commit.ci

…s into gan_review

otaj

Hi, all in all, it looks good, thank you! 🎉 However, I'd like to be sure that we are not raising any deprecation/user/any other warnings. For this, I just opened #844 which should then be used in tests (when it gets merged).

otaj · 2022-07-27T09:43:16Z

tests/models/gans/integration/test_gans.py

@@ -13,6 +13,7 @@
    [
        pytest.param(MNISTDataModule, id="mnist"),
        pytest.param(CIFAR10DataModule, id="cifar10"),
+        pytest.param(STL10DataModule, id="stl10"),


I'd remove this test case, as it is very heavy dataset

…vision datamodule

…ting their test cases

shivammehta25 · 2022-07-27T15:28:42Z

Currently, all the modified classes and their test cases pass but with the exception that we filter PossibleUserWarning resulting in user suggestions as mentioned in #844 (comment). Also first, #844 should be merged before merging this one as I call the catch_warnings in every test case that I have modified or added.

otaj · 2022-07-27T16:30:46Z

Awesome work! Let's wait for #844 to see if the tests are passing on CI as well, but otherwise it looks good!

… gan_review

otaj

LGTM! Let's wait for test and get this merged 👍 💪 🚀

luca-medeiros · 2022-07-30T00:52:29Z

pl_bolts/datamodules/vision_datamodule.py

@@ -30,6 +27,9 @@ def __init__(
        shuffle: bool = True,
        pin_memory: bool = True,
        drop_last: bool = False,
+        train_transforms: Optional[Callable] = None,


Shouldn't we include these transforms into the class docstring?

I agree we should add it. What will be an ideal way of doing this? Do I need to create another pull request for this?

I agree with this as well, good catch @luca-medeiros!

@shivammehta007, yes, opening a new PR is the only option (not even I have push rights to master 😂). Since this PR is already merged, there really is no other option. Just write there it's a followup of #843

@otaj

Seems you are the only member doing reviews for #839.
What about assembling a small (3~5 people) team to help you out with it? I would be willing to help review as well!

@luca-medeiros Oh, absolutely! That's the whole point of our Slack channel. I think you're not in there yet, can you ping me on PL Slack (@Ota) and I will add you there?

shivammehta25 · 2022-08-02T11:01:58Z

As discussed adding docstring in a separate PR #847.

shivammehta25 added 3 commits July 26, 2022 15:52

removing deprecated argument refresh rate to progressbar

d1d7745

re structuring test folder and adding generator tests

a9161a9

typo fix

857218d

github-actions bot added the model label Jul 26, 2022

pre-commit-ci bot and others added 6 commits July 26, 2022 16:13

[pre-commit.ci] auto fixes from pre-commit.com hooks

7c85262

for more information, see https://pre-commit.ci

Adding discriminator unit test

10886c3

merging pre-commit

e51b16f

[pre-commit.ci] auto fixes from pre-commit.com hooks

3807c56

for more information, see https://pre-commit.ci

running pre-commit locally

6f2e848

Merge branch 'gan_review' of github.com:shivammehta007/lightning-bolt…

bac6e2c

…s into gan_review

otaj reviewed Jul 27, 2022

View reviewed changes

otaj mentioned this pull request Jul 27, 2022

Major revision of Bolts #839

Open

shivammehta25 added 2 commits July 27, 2022 16:26

overriding the getters and setters of {train/val/test}_transforms in …

2aae0d1

…vision datamodule

Adding MNISTDataModule, CIFAR10DataModule, VisionDataModule with upda…

7879aa2

…ting their test cases

filtering num worker exception

72beca6

shivammehta25 changed the title ~~[WIP] Reviewing GAN basics~~ Reviewing GAN basics, VisionDataModule, MNISTDataModule, CIFAR10DataModule Jul 27, 2022

shivammehta25 marked this pull request as ready for review July 27, 2022 16:52

shivammehta25 requested review from Borda, akihironitta, ethanwharris and awaelchli as code owners July 27, 2022 16:52

Merge branch 'master' of github.com:Lightning-AI/lightning-bolts into…

e8d8f22

… gan_review

shivammehta25 requested a review from otaj July 29, 2022 09:40

shivammehta25 added 3 commits July 29, 2022 11:54

Fixing mypy errors and adding new transforms to the class instances

6422e23

fixing test's accelerator

bace5a4

removing further mypy errors

3c9415b

otaj approved these changes Jul 29, 2022

View reviewed changes

mergify bot added the ready label Jul 29, 2022

otaj merged commit acc0c98 into Lightning-Universe:master Jul 29, 2022

shivammehta25 deleted the gan_review branch July 29, 2022 13:19

luca-medeiros reviewed Jul 30, 2022

View reviewed changes

shivammehta25 restored the gan_review branch August 1, 2022 10:24

shivammehta25 mentioned this pull request Aug 2, 2022

Followup of #843 - adding docstring #847

Merged

8 tasks

otaj pushed a commit that referenced this pull request Aug 2, 2022

Followup of #843 - adding docstring (#847)

5481b6e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reviewing GAN basics, VisionDataModule, MNISTDataModule, CIFAR10DataModule #843

Reviewing GAN basics, VisionDataModule, MNISTDataModule, CIFAR10DataModule #843

shivammehta25 commented Jul 26, 2022 •

edited by otaj

Loading

otaj left a comment

otaj Jul 27, 2022

shivammehta25 commented Jul 27, 2022 •

edited

Loading

otaj commented Jul 27, 2022

otaj left a comment

luca-medeiros Jul 30, 2022

shivammehta25 Aug 1, 2022

otaj Aug 2, 2022 •

edited

Loading

luca-medeiros Aug 2, 2022

otaj Aug 2, 2022

shivammehta25 commented Aug 2, 2022

Reviewing GAN basics, VisionDataModule, MNISTDataModule, CIFAR10DataModule #843

Reviewing GAN basics, VisionDataModule, MNISTDataModule, CIFAR10DataModule #843

Conversation

shivammehta25 commented Jul 26, 2022 • edited by otaj Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

otaj left a comment

Choose a reason for hiding this comment

otaj Jul 27, 2022

Choose a reason for hiding this comment

shivammehta25 commented Jul 27, 2022 • edited Loading

otaj commented Jul 27, 2022

otaj left a comment

Choose a reason for hiding this comment

luca-medeiros Jul 30, 2022

Choose a reason for hiding this comment

shivammehta25 Aug 1, 2022

Choose a reason for hiding this comment

otaj Aug 2, 2022 • edited Loading

Choose a reason for hiding this comment

luca-medeiros Aug 2, 2022

Choose a reason for hiding this comment

otaj Aug 2, 2022

Choose a reason for hiding this comment

shivammehta25 commented Aug 2, 2022

shivammehta25 commented Jul 26, 2022 •

edited by otaj

Loading

shivammehta25 commented Jul 27, 2022 •

edited

Loading

otaj Aug 2, 2022 •

edited

Loading