Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support number of channels!=3 in YOLOConfiguration #806

Merged
merged 6 commits into from
May 4, 2022

Conversation

kfirgedal
Copy link
Contributor

@kfirgedal kfirgedal commented Feb 17, 2022

What does this PR do?

Fix an issue where the number of input channels in YOLOConfiguration was hardcoded to 3 instead of using "channels" from the .cfg file.

Fixes # (805)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

pl_bolts/models/detection/yolo/yolo_config.py Outdated Show resolved Hide resolved
Co-authored-by: Seppo Enarvi <seppo.git@marjaniemi.com>
@senarvi
Copy link
Contributor

senarvi commented Mar 7, 2022

@Borda how about merging this?

@mergify mergify bot removed the ready label Apr 18, 2022
@Borda Borda merged commit 55cb279 into Lightning-Universe:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YOLOConfiguration does not support number of channels!=3
5 participants