Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Torch ORT Callback, re-write callback section #720

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Aug 31, 2021

What does this PR do?

Adds the Torch ORT Callback to lightning bolts, refactor the docs to neaten the structure up + add helpers for tests.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added callback documentation Improvements or additions to documentation labels Aug 31, 2021
@SeanNaren SeanNaren self-assigned this Aug 31, 2021
Copy link
Contributor

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

docs/source/callbacks/torch_ort.rst Outdated Show resolved Hide resolved
@SeanNaren SeanNaren enabled auto-merge (squash) August 31, 2021 12:54
@ananyahjha93 ananyahjha93 self-requested a review August 31, 2021 13:32
@ananyahjha93 ananyahjha93 enabled auto-merge (squash) August 31, 2021 13:33
@SeanNaren SeanNaren enabled auto-merge (squash) August 31, 2021 13:41
@SeanNaren SeanNaren merged commit 7c0fcdd into master Aug 31, 2021
@SeanNaren SeanNaren deleted the feat/torch_ort branch August 31, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants