Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed double softmax bug in SSLEvaluator #663

Merged
merged 5 commits into from
Jun 16, 2021

Conversation

norabelrose
Copy link
Contributor

What does this PR do?

Fixes #662

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #663 (cb83c2e) into master (b087892) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   25.54%   25.54%           
=======================================
  Files         118      118           
  Lines        7110     7110           
=======================================
  Hits         1816     1816           
  Misses       5294     5294           
Flag Coverage Δ
cpu 25.54% <0.00%> (ø)
pytest 25.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/callbacks/ssl_online.py 25.00% <0.00%> (ø)
pl_bolts/models/self_supervised/evaluator.py 38.88% <0.00%> (ø)
pl_bolts/models/self_supervised/ssl_finetuner.py 24.13% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b087892...cb83c2e. Read the comment docs.

pl_bolts/models/self_supervised/evaluator.py Show resolved Hide resolved
pl_bolts/models/self_supervised/evaluator.py Outdated Show resolved Hide resolved
@Borda Borda added the ready label Jun 16, 2021
Copy link
Contributor

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

ethanwharris and others added 2 commits June 16, 2021 09:26
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ignore my previous comment

@Borda
Copy link
Member

Borda commented Jun 16, 2021

LGTM
ignore my previous comment

I do not see any :P

@Borda Borda merged commit 6b7358c into Lightning-Universe:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Softmax applied twice in SSLOnlineEvaluator callback
4 participants