Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added encoder argument to BYOL constructor #637

Merged
merged 10 commits into from
Jun 16, 2021
Merged

Added encoder argument to BYOL constructor #637

merged 10 commits into from
Jun 16, 2021

Conversation

garryod
Copy link
Contributor

@garryod garryod commented May 10, 2021

What does this PR do?

Adds functionality requested in #383

  • Added base encoder and MLP dimension (encoder_out_dim, projector_hidden_size & projector_out_dim) arguments to BYOL constructor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@github-actions github-actions bot added the model label May 10, 2021
@garryod garryod changed the title Byol encoder opt Added encoder argument to BYOL constructor May 10, 2021
@mergify mergify bot removed the has conflicts label May 12, 2021
CHANGELOG.md Show resolved Hide resolved
@Borda Borda added the ready label Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #637 (124fd1b) into master (b087892) will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   25.54%   25.54%           
=======================================
  Files         118      118           
  Lines        7110     7110           
=======================================
  Hits         1816     1816           
  Misses       5294     5294           
Flag Coverage Δ
cpu 25.54% <25.00%> (ø)
pytest 25.54% <25.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/models/self_supervised/byol/models.py 33.33% <20.00%> (ø)
...l_bolts/models/self_supervised/byol/byol_module.py 22.34% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b087892...124fd1b. Read the comment docs.

@Borda Borda merged commit 3636142 into Lightning-Universe:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants