Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove momentum updating from val step and add separate val queue #631

Merged
merged 37 commits into from
Jul 4, 2021

Conversation

maximzubkov
Copy link
Contributor

What does this PR do?

This pull request fixes the problem discussed in the following issues #615 #630

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

Changes:

  • Remove _momentum_update_key_encoder and _dequeue_and_enqueue from forward
  • Add separate val_queue and val_queue_ptr
  • Return key form forward

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #631 (6d31284) into master (0045e64) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   72.64%   72.25%   -0.40%     
==========================================
  Files         119      119              
  Lines        7352     7356       +4     
==========================================
- Hits         5341     5315      -26     
- Misses       2011     2041      +30     
Flag Coverage Δ
cpu 72.25% <100.00%> (-0.40%) ⬇️
pytest 72.25% <100.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._bolts/models/self_supervised/moco/moco2_module.py 58.82% <100.00%> (+0.99%) ⬆️
pl_bolts/datasets/cifar10_dataset.py 72.04% <0.00%> (-25.81%) ⬇️
pl_bolts/datasets/base_dataset.py 81.39% <0.00%> (-13.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0045e64...6d31284. Read the comment docs.

@Borda Borda added the ready label May 10, 2021
@mergify mergify bot removed the has conflicts label May 12, 2021
@maximzubkov maximzubkov requested a review from Borda May 24, 2021 11:26
@Borda
Copy link
Member

Borda commented Jun 16, 2021

@ananyahjha93 mind check

@Borda Borda requested a review from ethanwharris June 21, 2021 18:41
@mergify mergify bot requested a review from awaelchli as a code owner June 21, 2021 18:44
@Borda Borda removed the ready label Jun 24, 2021
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maximzubkov Thank you for sending the fix! LGTM!

@ananyahjha93 Could you double-check the change here?

@akihironitta akihironitta added the fix fixing issues... label Jun 27, 2021
@Borda Borda merged commit 270867c into Lightning-Universe:master Jul 4, 2021
@sugatoray sugatoray mentioned this pull request Jul 4, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixing issues... model ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants