Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add multi-GPU #585

Merged
merged 34 commits into from
Mar 10, 2021
Merged

CI: add multi-GPU #585

merged 34 commits into from
Mar 10, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 9, 2021

What does this PR do?

add multi-GPU CI
Fixes #553

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added enhancement New feature or request ci/cd Continues Integration and delivery labels Mar 9, 2021
@Borda Borda marked this pull request as ready for review March 9, 2021 23:58
@pep8speaks
Copy link

pep8speaks commented Mar 10, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-10 12:11:44 UTC

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #585 (e14a75d) into master (41ebb3e) will decrease coverage by 2.53%.
The diff coverage is 55.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
- Coverage   76.59%   74.05%   -2.54%     
==========================================
  Files         117      117              
  Lines        6852     6864      +12     
==========================================
- Hits         5248     5083     -165     
- Misses       1604     1781     +177     
Flag Coverage Δ
cpu 26.30% <50.00%> (+0.10%) ⬆️
pytest 26.30% <50.00%> (+0.10%) ⬆️
unittests 73.54% <55.26%> (-2.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datasets/imagenet_dataset.py 20.00% <ø> (-0.46%) ⬇️
...lts/models/self_supervised/simclr/simclr_module.py 57.84% <ø> (-13.73%) ⬇️
pl_bolts/models/self_supervised/ssl_finetuner.py 24.13% <ø> (ø)
pl_bolts/models/self_supervised/cpc/cpc_module.py 21.25% <11.76%> (-0.17%) ⬇️
..._bolts/models/self_supervised/cpc/cpc_finetuner.py 19.35% <50.00%> (ø)
..._bolts/models/self_supervised/moco/moco2_module.py 64.18% <50.00%> (-7.44%) ⬇️
pl_bolts/models/self_supervised/__init__.py 100.00% <100.00%> (ø)
...bolts/models/self_supervised/amdim/amdim_module.py 91.26% <100.00%> (-5.48%) ⬇️
...l_bolts/models/self_supervised/byol/byol_module.py 60.24% <100.00%> (-22.69%) ⬇️
pl_bolts/models/self_supervised/cpc/__init__.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ebb3e...e14a75d. Read the comment docs.

@Borda Borda enabled auto-merge (squash) March 10, 2021 11:52
@Borda Borda mentioned this pull request Mar 10, 2021
3 tasks
@Borda Borda disabled auto-merge March 10, 2021 12:49
@Borda Borda merged commit 435d8d4 into master Mar 10, 2021
@Borda Borda deleted the ci/azure branch March 10, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPCv2 does not work, issue with online evaluator
2 participants