Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PT 1.8 compatibility issue #580

Merged
merged 10 commits into from
Mar 9, 2021
Merged

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Mar 6, 2021

What does this PR do?

Fixes PT 1.8 compatibility issue

  • fix torch._six
  • fix assert_allclose doesn't check shape PR
  • fix MNIST User Agent issue.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the datamodule Anything related to datamodules label Mar 6, 2021
@kaushikb11 kaushikb11 added fix fixing issues... Priority High priority task and removed datamodule Anything related to datamodules labels Mar 6, 2021
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #580 (61dfe39) into master (4e1c150) will decrease coverage by 0.58%.
The diff coverage is 34.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   77.56%   76.97%   -0.59%     
==========================================
  Files         115      117       +2     
  Lines        6707     6836     +129     
==========================================
+ Hits         5202     5262      +60     
- Misses       1505     1574      +69     
Flag Coverage Δ
cpu 26.19% <28.75%> (-0.02%) ⬇️
pytest 26.19% <28.75%> (-0.02%) ⬇️
unittests 76.46% <34.37%> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/models/autoencoders/basic_ae/basic_ae_module.py 88.15% <ø> (ø)
.../models/autoencoders/basic_vae/basic_vae_module.py 91.75% <ø> (ø)
pl_bolts/models/vision/image_gpt/gpt2.py 100.00% <ø> (ø)
pl_bolts/models/gans/pix2pix/components.py 17.94% <17.94%> (ø)
pl_bolts/models/gans/pix2pix/pix2pix_module.py 22.44% <22.44%> (ø)
pl_bolts/datamodules/async_dataloader.py 22.05% <50.00%> (+1.16%) ⬆️
pl_bolts/datasets/imagenet_dataset.py 20.45% <75.00%> (+0.80%) ⬆️
pl_bolts/callbacks/byol_updates.py 100.00% <100.00%> (ø)
pl_bolts/datasets/__init__.py 100.00% <100.00%> (ø)
pl_bolts/models/__init__.py 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f5370...efe5de2. Read the comment docs.

requirements.txt Outdated Show resolved Hide resolved
@Lightning-Universe Lightning-Universe deleted a comment from kaushikb11 Mar 6, 2021
@kaushikb11 kaushikb11 changed the title Fix torch._six PT 1.8 compatibility issue Fix PT 1.8 compatibility issue Mar 7, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 9, 2021

Hello @kaushikb11! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-09 10:08:50 UTC

@Borda Borda merged commit 4d194d4 into Lightning-Universe:master Mar 9, 2021
@kaushikb11 kaushikb11 deleted the fix/torch branch March 9, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixing issues... Priority High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot import name 'PY3' from 'torch._six' on fresh install of bolts
3 participants