Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vision models to pl_bolts.models.vision #561

Merged

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Feb 16, 2021

What does this PR do?

Part of #427 and fixes #559.

# This will be disabled after this change:
from pl_bolts.models import GPT2, ImageGPT, SemSegment, UNet

# Use below after the change:
from pl_bolts.models.vision import GPT2, ImageGPT, SemSegment, UNet

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added this to In progress in Code Health / Refatoring via automation Feb 16, 2021
@github-actions github-actions bot removed the model label Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #561 (79a3104) into master (86e3f52) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #561   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files         115      115           
  Lines        6701     6701           
=======================================
  Hits         5199     5199           
  Misses       1502     1502           
Flag Coverage Δ
cpu 26.23% <100.00%> (ø)
pytest 26.23% <100.00%> (ø)
unittests 77.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/models/vision/image_gpt/gpt2.py 100.00% <ø> (ø)
pl_bolts/models/__init__.py 100.00% <100.00%> (ø)
pl_bolts/models/vision/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e3f52...8368cfa. Read the comment docs.

@akihironitta akihironitta changed the title Restructuring models [wip] Move vision models to pl_bolts.models.vision Feb 16, 2021
@akihironitta akihironitta mentioned this pull request Feb 16, 2021
8 tasks
@Borda Borda enabled auto-merge (squash) March 4, 2021 21:36
@Borda Borda disabled auto-merge March 4, 2021 21:37
@Borda Borda merged commit 2964880 into Lightning-Universe:master Mar 4, 2021
Code Health / Refatoring automation moved this from In progress to Done Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Bolts Vision Models not working
2 participants