Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back RL #257

Merged
merged 7 commits into from
Oct 7, 2020
Merged

add back RL #257

merged 7 commits into from
Oct 7, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 28, 2020

What does this PR do?

Adding back RL

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #257 into master will increase coverage by 0.02%.
The diff coverage is 88.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   87.89%   87.91%   +0.02%     
==========================================
  Files          73       88      +15     
  Lines        3586     4685    +1099     
==========================================
+ Hits         3152     4119     +967     
- Misses        434      566     +132     
Flag Coverage Δ
#cpu 24.50% <1.16%> (-7.43%) ⬇️
#pytest 24.50% <1.16%> (-7.43%) ⬇️
#unittests 87.36% <88.15%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/models/vision/__init__.py 100.00% <ø> (ø)
pl_bolts/models/rl/common/cli.py 11.76% <11.76%> (ø)
pl_bolts/datamodules/cifar10_dataset.py 96.80% <50.00%> (-1.02%) ⬇️
pl_bolts/models/rl/dqn_model.py 80.23% <80.23%> (ø)
pl_bolts/models/rl/noisy_dqn_model.py 82.60% <82.60%> (ø)
pl_bolts/models/rl/common/memory.py 83.18% <83.18%> (ø)
pl_bolts/models/rl/per_dqn_model.py 86.88% <86.88%> (ø)
pl_bolts/models/rl/__init__.py 88.88% <88.88%> (ø)
pl_bolts/models/rl/common/networks.py 89.36% <89.36%> (ø)
pl_bolts/models/rl/common/gym_wrappers.py 89.65% <89.65%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e8be3...ab26f7f. Read the comment docs.

Borda and others added 2 commits September 28, 2020 14:32
* Updated DQN with implicit experience source

* Updated noisy and per dqn

* Updated reinforce and vpg args

* Update integration tests for new args

* Updated unit tests for new args and explicit train batch method

* Fixed linting/docs error

* space

* CI

* fix typing err

* fix typing err

* fix typing err

Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: William Falcon <waf2107@columbia.edu>
@Borda
Copy link
Member Author

Borda commented Sep 28, 2020

later this will be merged without squash eventually in the command line to keep the contributions...

@pep8speaks
Copy link

pep8speaks commented Sep 28, 2020

Hello @Borda! Thanks for updating this PR.

Line 313:30: W504 line break after binary operator
Line 314:52: W504 line break after binary operator

Comment last updated at 2020-09-28 16:00:55 UTC

@Borda Borda marked this pull request as ready for review September 28, 2020 16:50
@williamFalcon williamFalcon merged commit c3e11f1 into master Oct 7, 2020
@Borda Borda deleted the master_RL branch October 7, 2020 18:21
@Borda Borda added this to Done in Reinforcement Learning Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

4 participants