Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYOL: Move unnecessary dependencies to "if __name__ == '__main__'" section #176

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

sorenrasmussenai
Copy link
Contributor

Move imports, to the "if name == 'main' section.

What does this PR do?

Avoids importing unnecessary stuff, among them a cv2 import via the SimCLR transform modules, when importing BYOL

Move imports, to the "if __name__ == '__main__' section.
This avoids importing unnecessary stuff, among them a cv2 import via the SimCLR transform modules
@pep8speaks
Copy link

pep8speaks commented Sep 1, 2020

Hello @sorenrasmussenai! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-01 20:41:05 UTC

@mergify mergify bot requested a review from Borda September 1, 2020 09:26
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #176 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   91.03%   91.03%   -0.01%     
==========================================
  Files          89       89              
  Lines        4073     4071       -2     
==========================================
- Hits         3708     3706       -2     
  Misses        365      365              
Flag Coverage Δ
#unittests 91.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l_bolts/models/self_supervised/byol/byol_module.py 96.29% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf38307...037384e. Read the comment docs.

@williamFalcon williamFalcon merged commit 25d50bb into Lightning-Universe:master Sep 1, 2020
@Borda Borda added the fix fixing issues... label Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixing issues...
Development

Successfully merging this pull request may close these issues.

None yet

4 participants