Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI continously failing #18

Open
pierresegonne opened this issue Oct 22, 2020 · 1 comment
Open

CI continously failing #18

pierresegonne opened this issue Oct 22, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@pierresegonne
Copy link

pierresegonne commented Oct 22, 2020

Problem

The template test test_classifier.py does not pass when triggered as a GitHub action.

The issue comes from imports. Indeed the import from project.datasets.mnist import mnist is erroneous. There is no datasets folder in project because datasets is ignored (see l.37 of .gitignore).

Pulling the MNIST dataset everytime the GitHub action is triggered does not seem reasonable. My proposal would be to have a samples_datasets/ subfolder in test, not ignored, with a limited number of data points, and to use that for testing.

If anyone agree that it's a reasonable way to go, I'll create a PR :)

@Borda
Copy link
Member

Borda commented Apr 5, 2021

yes, some files are missing, probably @williamFalcon has them locally,,,

@Borda Borda added the bug Something isn't working label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants