Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irregular timing for 24h update cycle. #3

Open
kalleka opened this issue Jul 7, 2024 · 0 comments · May be fixed by #4
Open

Irregular timing for 24h update cycle. #3

kalleka opened this issue Jul 7, 2024 · 0 comments · May be fixed by #4

Comments

@kalleka
Copy link

kalleka commented Jul 7, 2024

Hi. Nice script.

  1. For a 24h calculation cycle the server update time alternates between 23:00 and 00:00. In the latter case that could potentially cause the task scheduled at 00:00 to be missed as the trigger event had already passed. By adding isToday check to isTsAfterChkT should prevent that.
  2. All the clients are sending update requests to server during the first minute of an hour. Adding some random minutes to isChkT would reduce the server load in case the script turns out to be very popular :)
  3. The next heating calculation time printed in the log was not correct (the current hour was reported instead). The proposed patch contains a modified nextChkHr() function that corrects the issue.
@kalleka kalleka linked a pull request Jul 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant