-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small headsup #80
Comments
Hey, Yeah I've been checking your parser every now and then to see if you are done with CS2. Nice to see that you got it working! I especially like this function 🤯
This is actually very interesting, because I thought this idea wasn't possible as I thought that I'm forced to to branching down the line but seems like its just due to how my fields/traversing is set up. I kind of gave up understanding the sendtable/serializer/field logic at some point but this gave me new hope. I'll definitely take a deeper look at how you made it, as I cringe every time I have to deal with the current code. |
The function you mention is my try to implement this the fastest way possible. There is a class The code that converts the sendtables into a nested structure of fields is here The code went through several revisions since Dota Source 2 first came out in 2017 (iirc), and it is hack free (apart from one single one I put in for CS2). |
After some poking around, I would like to implement "fields" the way you did it if you don't mind (of course with a mention where the idea came from). The implementation is sooo much more understandable. |
I don't mind at all! |
Thanks |
Hi,
whenever a new Source 1/2 replay parser comes out, I read their code to find out how they did stuff.
Especially some comments in the send table parsing code made me smile.
Tough stuff, I know.
I think my codebase (https://github.com/skadistats/clarity) has a quite nice implementation, so, if you missed it before, feel free to have a look.
Good work anyway! Keep it on!
The text was updated successfully, but these errors were encountered: