Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weapon_paint_seed should be an integer #158

Closed
thwonghin opened this issue Apr 5, 2024 · 5 comments
Closed

weapon_paint_seed should be an integer #158

thwonghin opened this issue Apr 5, 2024 · 5 comments

Comments

@thwonghin
Copy link
Contributor

thwonghin commented Apr 5, 2024

For some reason weapon_paint_seed prop has floating points in the output of parse_ticks, while it should be an integer. I don't know if I should round up or round down to have the correct value.

@LaihoE
Copy link
Owner

LaihoE commented Apr 5, 2024

Its a bit wonky atm, but it should not have any decimal values if it works correctly. ie value should be 370.0 --> 370

@LaihoE
Copy link
Owner

LaihoE commented Apr 9, 2024

ah I was mixing it up with another thing. Are you sure it really is an integer? I think its really a float but people just round it?

@thwonghin
Copy link
Contributor Author

thwonghin commented Apr 10, 2024

ah I was mixing it up with another thing. Are you sure it really is an integer? I think its really a float but people just round it?

Honesly I don't really know what's the internal data representation of a paint seed.

It looks like people always see it as an integer (between 0-1000). I googled a bit and find this article about seed distrubution, the values it plots do not have decimal places.

And there are many skin sites also display it as an integer.

@LaihoE
Copy link
Owner

LaihoE commented Apr 10, 2024

I think you are right. Maybe it should be an int after all. I just find it odd how the parser works without failing even with incorrect decoding of the value. I'll have to take a look at it.

@LaihoE
Copy link
Owner

LaihoE commented Aug 6, 2024

#200

Fixed here.

@LaihoE LaihoE closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants