Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsePlayerInfo performance #154

Closed
ChetdeJong opened this issue Mar 26, 2024 · 2 comments
Closed

parsePlayerInfo performance #154

ChetdeJong opened this issue Mar 26, 2024 · 2 comments

Comments

@ChetdeJong
Copy link

Hi,

I'm trying to get players info from number of demos with parsePlayerInfo
However I noticed it's much less performant, than parsing some event say round_announce_match_start and then one tick from it, to get the same data.

I'm not sure if there's issue with parser or just it is what it is.

This is the result I get when parsing 44 demos:

parsePlayerInfo: 13.306s
parseEventAndTick: 6.574s

I'm running JS script on 6 worker threads and demos are on SSD.

Script:
demoParserTest.zip

@LaihoE
Copy link
Owner

LaihoE commented Apr 10, 2024

Ah you are right, the parsePlayerInfo is unreasonably slow. This could be fixed but my plan is to move away from these separate functions into simple game events. So you would use something like "player_connect" event in the future.

@LaihoE
Copy link
Owner

LaihoE commented Aug 6, 2024

#201

player_info does not parse entities anymore and should be very fast now.

@LaihoE LaihoE closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants