Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support querying of m_aimPunchAngle & m_aimPunchAngleVel #152

Closed
mannall opened this issue Mar 23, 2024 · 2 comments
Closed

feat: support querying of m_aimPunchAngle & m_aimPunchAngleVel #152

mannall opened this issue Mar 23, 2024 · 2 comments

Comments

@mannall
Copy link

mannall commented Mar 23, 2024

Currently demoparser doesn't support querying of the weapon aimpunch angle/velocity properties. I suspect because they are vec3's this makes them quite annoying to deal with? I managed to implement this by duplicating the logic for pitch/yaw (i.e. fn find_pitch_or_yaw -> fn find_aim_punch_pitch_or_yaw) and making it a custom property, but I guess this is quite lousy.

@LaihoE
Copy link
Owner

LaihoE commented Mar 24, 2024

quite the opposite, duplicating the logic for pitch/yaw would be the better option. Its faster this way and working with arrays inside dataframes in python is especially painful.

If you want to submit a pr then we can merge it.

@LaihoE
Copy link
Owner

LaihoE commented Aug 6, 2024

Fixed here: #205

@LaihoE LaihoE closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants