Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare use of new should be replaced with smart pointer #14

Open
brettviren opened this issue Jan 10, 2022 · 0 comments
Open

Bare use of new should be replaced with smart pointer #14

brettviren opened this issue Jan 10, 2022 · 0 comments

Comments

@brettviren
Copy link
Member

A few places such as in the depo sources, a bare new is used. The heap object is correctly deleted in the destructor. In this particular case, a unique_ptr would provide a more modern idiom if also identical behavior.

Note that components are held by shared_ptr and those that provide WCT flow graph nodes tend to live for the entire job, in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant