Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract out common "style" logic #491

Closed
kezz opened this issue Nov 2, 2021 · 0 comments · Fixed by #501
Closed

Abstract out common "style" logic #491

kezz opened this issue Nov 2, 2021 · 0 comments · Fixed by #501

Comments

@kezz
Copy link
Member

kezz commented Nov 2, 2021

There are three objects which can be styles; Style, Component and ComponentBuilder. Each of these three classes contain different methods for setting elements of the style and duplicated implementation details.

If style logic could be abstracted into a Styleable(?) interface, the API could be unified and the implementation of some methods could be shared. Additionally, this would allow for better abstraction, aiding developers who are manipulating the style of objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants