Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-card-display): remove line links #844

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Leopoldthecoder
Copy link
Member

Summary

This PR removes line links when format is 'yaml'.
image

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@Leopoldthecoder Leopoldthecoder requested review from a team as code owners October 18, 2023 07:01
@aanchalm01
Copy link
Contributor

Instead of removing :show-line-number-links="true" for yaml can you instead add that when we have language="json" so that it matches the Figma design (the link I provided in Slack) ? Thanks!

Copy link
Contributor

@aanchalm01 aanchalm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Leopoldthecoder Leopoldthecoder merged commit d3d5ebd into main Oct 18, 2023
18 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/config-card-yml branch October 18, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants