-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ktableview): disable column visibility dropdown [KHCP-13248] #2392
Conversation
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the sandbox to help testing? The code looks good to me.
I added a sandbox example for functional verification but I will remove it before merging this PR (I don't think we need to keep the example for every arbitrary use case in the sandbox). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, sorry for the confusion. Should we call out this behavior in the docs somewhere?
I'll make a note to update docs when I'm working on KTableData. Update: ignore what I said above, follow up PR updating docs: #2402 |
## [9.7.1](v9.7.0...v9.7.1) (2024-09-17) ### Bug Fixes * **ktableview:** disable column visibility dropdown [KHCP-13248] ([#2392](#2392)) ([65890a2](65890a2))
🎉 This PR is included in version 9.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Jira: https://konghq.atlassian.net/browse/KHCP-13248
KTable and KTableView toolbar default items include bulk actions dropdown (only supported in KTableView) and column visibility menu (screenshot).
Changes:
Instead of hiding toolbar default items in loading and empty states at all times, only hide them in those states when toolbar slot is NOT provided. Otherwise, display those toolbar default items in disabled state to avoid layout shifts when table switches states (e.g. loading -> empty -> loading -> success).