Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ai-proxy): add option to return model name in response header #13472

Merged
merged 3 commits into from
Aug 9, 2024
Merged

feat(ai-proxy): add option to return model name in response header #13472

merged 3 commits into from
Aug 9, 2024

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented Aug 8, 2024 •
edited
Loading

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@fffonion fffonion mentioned this pull request Aug 8, 2024
Merged
3 tasks
@fffonion @liverpool8056
Update spec/02-integration/09-hybrid_mode/09-config-compat_spec.lua
922442f 
Co-authored-by: Robin Xiang <liverpool8056@163.com>
@fffonion fffonion merged commit 87d908f into master Aug 9, 2024
27 checks passed
@fffonion fffonion deleted the ai-proxy-model-header branch August 9, 2024 08:03
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13472-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13472-to-master-to-upstream
git checkout -b cherry-pick-13472-to-master-to-upstream
ancref=$(git merge-base 0f73339b558497d4ecd4d0fb64ad866270ff164b 922442f795abf54a1a597aa0af00e296e98c319f)
git cherry-pick -x $ancref..922442f795abf54a1a597aa0af00e296e98c319f

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 9, 2024
@fffonion
Copy link
Contributor Author

fffonion commented Aug 9, 2024

will do cherrypick as part of https://github.com/Kong/kong-ee/pull/9912

ProBrian pushed a commit that referenced this pull request Aug 13, 2024
@fffonion @ProBrian
feat(ai-proxy): add option to return model name in response header (#…
e69ebdf 
…13472)
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 13, 2024
oowl pushed a commit that referenced this pull request Aug 15, 2024
@fffonion
feat(ai-proxy): add option to return model name in response header (#…
34b048e 
…13472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowl oowl oowl approved these changes

@liverpool8056 liverpool8056 liverpool8056 approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@tysoekong tysoekong Awaiting requested review from tysoekong

@jschmid1 jschmid1 Awaiting requested review from jschmid1

Assignees

@fffonion fffonion

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer schema-change-noteworthy size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fffonion @team-gateway-bot @oowl @liverpool8056 @StarlightIbuki @kikito