fix(runloop): Fixed an issue where setting tls_verify to false didn't override the global level config proxy_ssl_verify
#13470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
cherry-pick kong-ee
catbro666
force-pushed
the
fti-6095-tls-verify-false
branch
2 times, most recently
from
3f576af
to
9168612
Compare
liverpool8056
approved these changes
Aug 9, 2024
tzssangglass
reviewed
Aug 9, 2024
catbro666
force-pushed
the
fti-6095-tls-verify-false
branch
from
9168612
to
84cc974
Compare
tzssangglass
approved these changes
Aug 13, 2024
outsinre
reviewed
Aug 13, 2024
catbro666
force-pushed
the
fti-6095-tls-verify-false
branch
from
84cc974
to
b196023
Compare
outsinre
approved these changes
Aug 13, 2024
…dn't override the global level config `proxy_ssl_verify` https://konghq.atlassian.net/browse/FTI-6095
catbro666
force-pushed
the
fti-6095-tls-verify-false
branch
from
b196023
to
df8d08c
Compare
catbro666
changed the title
tls_verify to false didn't override the system level config proxy_ssl_verifytls_verify to false didn't override the global level config proxy_ssl_verify
|
Successfully created cherry-pick PR for |
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
…g `proxy_ssl_verify ` (#13470) Should also set_upstream_ssl_verify when `tls_verify` is false, because the global level config `proxy_ssl_verify` may be `on`. https://konghq.atlassian.net/browse/FTI-6095 (cherry picked from commit cfd997f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should also set_upstream_ssl_verify when
tls_verifyis false, because the global level configproxy_ssl_verifymay beon.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix https://konghq.atlassian.net/browse/FTI-6095