Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/balancer): fix a bug that the host_header not set correctly #13135

Merged
merged 6 commits into from
Jun 3, 2024
Merged

fix(core/balancer): fix a bug that the host_header not set correctly #13135

merged 6 commits into from
Jun 3, 2024

Conversation

liverpool8056
Copy link
Contributor

@liverpool8056 liverpool8056 commented Jun 1, 2024 •
edited
Loading

Summary

fix a bug that the host_header can not be set correctly as Host header in requests to upstream when retries happen

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-5987

@github-actions github-actions bot added core/balancer cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jun 1, 2024
@windmgc windmgc requested review from locao and oowl June 3, 2024 07:23
oowl
oowl approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vm-001
vm-001 reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@vm-001 vm-001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny code style

kong/runloop/balancer/init.lua Outdated Show resolved Hide resolved
liverpool8056 and others added 6 commits June 3, 2024 16:59
@liverpool8056
fix(core/balancer): fix a bug that the host_header configured for
7a51ef9 
upstream entity can not be set correctly in requests to upstream as
Host header when retries to upstream happen.

FTI-5987
@liverpool8056
update test case
e1a75bc
@liverpool8056
update
1edd8cc
@liverpool8056
revert hash_value initialization
f32b4cf
@liverpool8056 @vm-001
Update spec/02-integration/05-proxy/03-upstream_headers_spec.lua
8af1c6d 
Co-authored-by: Yusheng Li <leeys.top@gmail.com>
@liverpool8056 @vm-001
Update kong/runloop/balancer/init.lua
70bbcf8 
Co-authored-by: Yusheng Li <leeys.top@gmail.com>
@windmgc windmgc merged commit e90cafc into master Jun 3, 2024
25 checks passed
@windmgc windmgc deleted the fix-host-header-not-set branch June 3, 2024 10:10
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@liverpool8056 liverpool8056 mentioned this pull request Jun 4, 2024
Merged
3 tasks
locao pushed a commit that referenced this pull request Jun 21, 2024
@liverpool8056 @windmgc
fix(core/balancer): fix a bug that the host_header not set correctly (
eebc668 
#13135)

* fix(core/balancer): fix a bug that the `host_header` configured for
upstream entity can not be set correctly in requests to upstream as
Host header when retries to upstream happen.

FTI-5987

---------

Co-authored-by: Yusheng Li <leeys.top@gmail.com>
(cherry picked from commit e90cafc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vm-001 vm-001 vm-001 approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@oowl oowl oowl approved these changes

@locao locao Awaiting requested review from locao

Assignees

@liverpool8056 liverpool8056

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/balancer size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liverpool8056 @team-gateway-bot @vm-001 @tzssangglass @oowl @windmgc