Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes two mistakes in comments and removes one unused vk::MappedMemoryRange #301

Merged
merged 3 commits into from
Sep 11, 2022

Conversation

MiroPalmu
Copy link
Contributor

I was reading through implementation of Kompute and noticed couple small mistakes that should not effect any functionality.

This minor PR fixes them.

@MiroPalmu

This comment was marked as resolved.

Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
Signed-off-by: Miro Palmu <miro.palmu@helsinki.fi>
@MiroPalmu
Copy link
Contributor Author

Now with correct signoffs.

Also fixed the typo from #294. It had the same problem with signoff and it has not been updated in while so I just did the same correction and added it to his PR.

So if this is merged #294 should be closed.

@axsaucedo
Copy link
Member

Nice one @MiroPalmu - thank you for the contributions

@axsaucedo axsaucedo merged commit e8f051f into KomputeProject:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants