Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to remove authorizations::create from doc #1087

Closed
rafasashi opened this issue Oct 11, 2022 · 2 comments · Fixed by #1090
Closed

Suggestion to remove authorizations::create from doc #1087

rafasashi opened this issue Oct 11, 2022 · 2 comments · Fixed by #1090
Labels
documentation good first issue Ideal for your first contribution!

Comments

@rafasashi
Copy link
Contributor

rafasashi commented Oct 11, 2022

It seems that the following method doesn't exist any longer or am I missing a dependency?

$authorization = $github->api('authorizations')->create($data);

$authorization = $github->api('authorizations')->create(array('note' => 'Optional'), $code);

@acrobat
Copy link
Collaborator

acrobat commented Oct 23, 2022

These endpoints were indeed deprecated and removed in V3. (2fe12b8)

Can you send a PR to cleanup the docs @rafasashi? Thanks!

@acrobat acrobat added documentation good first issue Ideal for your first contribution! labels Oct 23, 2022
@rafasashi
Copy link
Contributor Author

rafasashi commented Oct 25, 2022

Thanks for the feedback @acrobat ! Here is the PR #1090

@acrobat acrobat linked a pull request Oct 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue Ideal for your first contribution!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants